Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move/rename experiment/nursery to greenhouse, document, enable for test-infra #6879

Merged
merged 2 commits into from
Feb 17, 2018
Merged

move/rename experiment/nursery to greenhouse, document, enable for test-infra #6879

merged 2 commits into from
Feb 17, 2018

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Feb 16, 2018 •
edited
Loading

  • moves / renames experiment/nursery to greenhouse
  • documents greenhouse a bit better
  • enables for test-infra (JUST pull-test-infra-bazel and the existing experimental / non-blocking jobs)

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2018
@BenTheElder BenTheElder changed the title move/rename experiment/nursery to greenhouse, document, enable for test-infra [WIP] move/rename experiment/nursery to greenhouse, document, enable for test-infra Feb 16, 2018
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 16, 2018
@BenTheElder
Copy link
Member Author

/assign @ixdy @krzyzacy @cjwagner
/area bazel
/area jobs

@BenTheElder BenTheElder mentioned this pull request Feb 17, 2018
Closed
12 tasks
@BenTheElder BenTheElder changed the title [WIP] move/rename experiment/nursery to greenhouse, document, enable for test-infra move/rename experiment/nursery to greenhouse, document, enable for test-infra Feb 17, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2018
@BenTheElder
Copy link
Member Author

Should be good to go 😄

@BenTheElder
Copy link
Member Author

/woof

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 17, 2018
krzyzacy
krzyzacy approved these changes Feb 17, 2018
View reviewed changes
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete experiment/nursery/deployment.yaml?

/lgtm
/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2018
@BenTheElder
Copy link
Member Author

delete experiment/nursery/deployment.yaml?

done, thanks!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 28d4597 into kubernetes:master Feb 17, 2018
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the config configmap

In response to this:

  • moves / renames experiment/nursery to greenhouse
  • documents greenhouse a bit better
  • enables for test-infra (JUST pull-test-infra-bazel and the existing experimental / non-blocking jobs)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the greenhouse branch February 17, 2018 01:31
@BenTheElder BenTheElder added the area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) label Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy approved these changes

Assignees

@krzyzacy krzyzacy

@cjwagner cjwagner

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bazel area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenTheElder @k8s-ci-robot @krzyzacy @cjwagner @ixdy